add {set,get,delete}_object_lock_config APIs #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
add-set-get-delete_object_lock_config-apis
branch
from
d90957d
to
df33308
Compare
balamurugana
force-pushed
the
add-set-get-delete_object_lock_config-apis
branch
from
df33308
to
15b30f7
Compare
|
do we need to add functional tests for these APIs? |
Many existing APIs do not have functional tests. Not sure whether tests are needed for these APIs. |
balamurugana
force-pushed
the
add-set-get-delete_object_lock_config-apis
branch
2 times, most recently
from
57b0faf
to
c84527c
Compare
poornas
requested changes
Oct 16, 2020
tests/unit/objectlockconfig.py
Outdated
| <Years>3</Years> | ||
| </DefaultRetention> | ||
| </Rule> | ||
| </ObjectLockConfiguration>""", |
There was a problem hiding this comment.
please fix the indentation here
There was a problem hiding this comment.
What do you mean by fixing indentation? Could you point me where exactly the problem?
There was a problem hiding this comment.
if you view the file xml is not indented ok
There was a problem hiding this comment.
The multi-lined string is indented correctly to python. Please print the string and let me know if I am missing it.
balamurugana
force-pushed
the
add-set-get-delete_object_lock_config-apis
branch
7 times, most recently
from
ccf35b9
to
012bece
Compare
balamurugana
force-pushed
the
add-set-get-delete_object_lock_config-apis
branch
from
012bece
to
e3cf139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.