Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: [windows] IE11 got error: Object doesn't support property or method 'assign' for browser client #3898

Closed
wey-gu opened this issue Mar 14, 2017 · 18 comments

Comments

@wey-gu
Copy link

wey-gu commented Mar 14, 2017

Expected Behavior

minio-server web-browser client got error from IE11 , which blocked the loading of initial authentication page.

Current Behavior

Below is errors from IE11 F12 mode:

SCRIPT438: Object doesn't support property or method 'assign'
File: index_bundle-2017-02-15T22-41-23Z.js, Line: 30, Column: 27472

Possible Solution

simular fault: rjsf-team/react-jsonschema-form#206

Steps to Reproduce (for bugs)

  1. Deploy minio.exe for windows 64 bit
  2. Access :9000 via IE 11

Your Environment

  • Version used:
Version: 2017-02-16T01:47:30Z
Release-Tag: RELEASE.2017-02-16T01-47-30Z
Commit-ID: 3d98311d9f4ceb78dba996dcdc0751253241e697
  • Environment name and version : Only minio.exe without http proxy.
  • Server type and version: refer to version above
  • Operating System and version: Windows 7 64bit
  • Link to your project: n/a
@krishnasrinivas
Copy link
Contributor

krishnasrinivas commented Mar 14, 2017

#3791

@harshavardhana
Copy link
Member

Can you validate the fix in #3884 on IE11 @rushenn ?

krishnasrinivas added a commit to krishnasrinivas/minio that referenced this issue Mar 14, 2017
krishnasrinivas added a commit to krishnasrinivas/minio that referenced this issue Mar 14, 2017
krishnasrinivas added a commit to krishnasrinivas/minio that referenced this issue Mar 15, 2017
@wey-gu
Copy link
Author

wey-gu commented Mar 16, 2017

@harshavardhana sorry for bothering, I downloaded the binary minio server for windows x64 while it's still old version, When could that download link be updated please?

@harshavardhana
Copy link
Member

@harshavardhana sorry for bothering, I downloaded the binary minio server for windows x64 while it's still old version, When could that download link be updated please?

We will update it soon @littlewey ..

@wey-gu
Copy link
Author

wey-gu commented Mar 20, 2017

@krishnasrinivas sorry it seems the mino.exe built on 2017-3-16 was still with this issue, it's still blocked in login interface. Should I raise another issue?

SCRIPT438: Object doesn't support property or method 'assign'
File: index_bundle-2017-03-15T17-49-51Z.js, Line: 30, Column: 22288
Version: 2017-03-16T21:50:32Z
Release-Tag: RELEASE.2017-03-16T21-50-32Z
Commit-ID: 5311eb22fd681a8cd4a46e2a872d46c2352c64e8

@krishnasrinivas
Copy link
Contributor

@rushenn can you try adding

{
  "plugins": ["transform-object-assign"]
}

to .babelrc? ping me for access to the windows machine. I can see the bug on IE11

reference: https://babeljs.io/docs/plugins/transform-object-assign/

@rushenn
Copy link
Member

rushenn commented Mar 20, 2017

@krishnasrinivas checking

@krishnasrinivas
Copy link
Contributor

@rushenn :

diff --git a/browser/app/index.js b/browser/app/index.js
index 26a1cc1..3afa865 100644
--- a/browser/app/index.js
+++ b/browser/app/index.js
@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+import 'babel-polyfill'
+
 import './less/main.less'
 
 import React from 'react'

this was the only way I could make it work. The webpack config solution was not working on IE11 for some reason.

You can undo transform-object-assign related changes.

@rushenn
Copy link
Member

rushenn commented Mar 21, 2017

@krishnasrinivas #3942

disrani-px pushed a commit to portworx/minio that referenced this issue Mar 22, 2017
@wey-gu
Copy link
Author

wey-gu commented Mar 29, 2017

Dear all,
Any update on this please?
Thanks!
BR//Wey

@harshavardhana
Copy link
Member

Master branch should be already fixed.

@deekoder deekoder changed the title IE11 got error: Object doesn't support property or method 'assign' for browser client browser: [windows] IE11 got error: Object doesn't support property or method 'assign' for browser client Apr 1, 2017
@deekoder deekoder added the fixed label Apr 1, 2017
@deekoder deekoder added this to the USS Akira milestone Apr 1, 2017
@deekoder deekoder closed this as completed Apr 1, 2017
@wey-gu
Copy link
Author

wey-gu commented Apr 5, 2017

Dear @harshavardhana sorry for bothering when could I expect the binary version with the issue fixed?

Many thanks!

@harshavardhana
Copy link
Member

Dear @harshavardhana sorry for bothering when could I expect the binary version with the issue fixed?

@littlewey it should be soon, we have been waiting on testing. You could use docker btw

docker pull minio/minio:edge

To get the latest UI changes until we make a new release.

@wey-gu
Copy link
Author

wey-gu commented Apr 12, 2017

@harshavardhana thanks a lot, the docker for windows requires win10 Pro(with hyper-v). I have to wait for the binary windows release. Looking forward to seeing its update .

BR//Wey

@wey-gu
Copy link
Author

wey-gu commented May 9, 2017

Update: best way to install docker in windows 7
choco install docker with chocolatey

@harshavardhana
Copy link
Member

Update: best way to install docker in windows 7
choco install docker with chocolatey

We have made the release.. btw you don't need to use minio/minio:edge anymore.

@wey-gu
Copy link
Author

wey-gu commented May 9, 2017

@harshavardhana Thanks, updated to latest released binary one, IE confirmed works perfectly fine.

@lock
Copy link

lock bot commented May 6, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants