Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: Update ui-assets.go #3899

Closed

Conversation

krishnasrinivas
Copy link
Contributor

Description

305952d did not have es6-object-assign module. Fixing it.

Motivation and Context

fix #3898 (comment)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@krishnasrinivas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @harshavardhana to be a potential reviewer.

@codecov-io
Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #3899 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3899      +/-   ##
==========================================
+ Coverage    72.7%   72.72%   +0.02%     
==========================================
  Files         166      166              
  Lines       21341    21341              
==========================================
+ Hits        15515    15520       +5     
+ Misses       4804     4800       -4     
+ Partials     1022     1021       -1
Impacted Files Coverage Δ
cmd/fs-v1-background-append.go 79.86% <0%> (ø)
cmd/posix.go 73.4% <0%> (+0.15%)
cmd/xl-v1-utils.go 92.11% <0%> (+0.82%)
cmd/xl-v1-metadata.go 72.85% <0%> (+0.95%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5e6070...a7fb9a2. Read the comment docs.

@krishnasrinivas
Copy link
Contributor Author

@rushenn is sending another PR using https://babeljs.io/docs/usage/polyfill/
closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browser: [windows] IE11 got error: Object doesn't support property or method 'assign' for browser client
3 participants