Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copyObject key rotation issue #10085

Merged
merged 1 commit into from
Jul 19, 2020
Merged

fix: copyObject key rotation issue #10085

merged 1 commit into from
Jul 19, 2020

Conversation

harshavardhana
Copy link
Member

Description

fix: copyObject key rotation issue

Motivation and Context

  • copyObject in-place decryption failed
    due to incorrect verification of headers
  • do not decode ETag when an object is encrypted
    with SSE-C, so that pre-conditions don't fail
    prematurely.

How to test this PR?

Use minio-go make functional-test by running a local TLS server minio server /tmp/{1..4} --certs-dir ../minio-go/testcerts

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@harshavardhana
fix: copyObject key rotation issue
95cd8a4 
- copyObject in-place decryption failed
  due to incorrect verification of headers
- do not decode ETag when object is encrypted
  with SSE-C, so that pre-conditions don't fail
  prematurely.
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-zoned.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

kannappanr
kannappanr approved these changes Jul 19, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit d53e560 into minio:master Jul 19, 2020
@harshavardhana harshavardhana deleted the fix-copy branch July 19, 2020 00:36
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Jul 21, 2020
@harshavardhana
fix: copyObject encryption from unencrypted object
22d867c 
This is a continuation of minio#10085
@harshavardhana harshavardhana mentioned this pull request Jul 21, 2020
Merged
6 tasks
harshavardhana added a commit that referenced this pull request Jul 21, 2020
@harshavardhana
fix: copyObject encryption from unencrypted object (#10102)
eb6bf45 
This is a continuation of #10085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannappanr kannappanr kannappanr approved these changes

@poornas poornas Awaiting requested review from poornas

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harshavardhana @minio-trusted @kannappanr