Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copyObject encryption from unencrypted object #10102

Merged
merged 1 commit into from Jul 21, 2020

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Jul 21, 2020

Description

fix: copyObject encryption from unencrypted object

Motivation and Context

This is a continuation of #10085

How to test this PR?

Start MinIO server with this PR

~ export MINIO_KMS_MASTER_KEY=...
~ minio server --certs-dir ../minio-go/testcerts /tmp/fs{1...4}

Run functional test

~ make functional-test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-zoned.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit eb6bf45 into minio:master Jul 21, 2020
@harshavardhana harshavardhana deleted the fix-copy branch July 21, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants