-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not return an error on expired credentials #12057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
policy might have an associated mapping with an expired user key, do not return an error during DeletePolicy for such situations - proceed normally as its an expected situation.
Mint Automation
12057-c777bbd/mint-compress-encrypt-dist-erasure.sh.log:
Deleting image on docker hub |
donatello
approved these changes
Apr 15, 2021
harshavardhana
added a commit
that referenced
this pull request
Apr 21, 2021
policy might have an associated mapping with an expired user key, do not return an error during DeletePolicy for such situations - proceed normally as its an expected situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: do not return an error on expired credentials
Motivation and Context
policy might have an associated mapping with an expired
user key, do not return an error during DeletePolicy
for such situations - proceed normally as its an
expected situation.
How to test this PR?
mc admin policy remove
might return an error in situationswhen an STS is expired but has a dangling key in userPolicyMap
Types of changes
Checklist:
commit-id
orPR #
here)