Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes monitoring in helm release #13238

Merged
merged 6 commits into from
Sep 18, 2021
Merged

Fixes monitoring in helm release #13238

merged 6 commits into from
Sep 18, 2021

Conversation

dyvol777
Copy link
Contributor

@dyvol777 dyvol777 commented Sep 17, 2021 •
edited

Fixes for #13236

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@harshavardhana
Copy link
Member

Make sure to have proper title for the fix @dyvol777

harshavardhana
harshavardhana requested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should generate release assets yourself @dyvol777 - that is up project admins to do.

@dyvol777
Copy link
Contributor Author

You should generate release assets yourself @dyvol777 - that is up project admins to do.

I'm sorry, could you help me? What should i do?

@dyvol777
Copy link
Contributor Author

Make sure to have proper title for the fix @dyvol777

Could you rename it for the right name?

@dyvol777 dyvol777 changed the title Fix #13236 Fixes monitoring in helm release Sep 17, 2021
harshavardhana
harshavardhana requested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you avoid doing ./helm-reindex.sh

@dyvol777
Copy link
Contributor Author

LGTM - can you avoid doing ./helm-reindex.sh

Or, sorry. Should i revert changes maded by run it?

@harshavardhana
Copy link
Member

Or, sorry. Should i revert changes maded by run it?

yes @dyvol777

@dyvol777
Copy link
Contributor Author

yes

Done @harshavardhana

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-zoned.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit 745782a into minio:master Sep 18, 2021
dyvol777 added a commit to dyvol777/minio that referenced this pull request Sep 18, 2021
@dyvol777
Split toleration, nodeSelector and affinity from main pods and jobs. …
9fce389 
…Fixed public monitoring from minio#13238
@dyvol777 dyvol777 mentioned this pull request Sep 18, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dyvol777 @harshavardhana @minio-trusted