New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm gcs gateway support #13810
Merged
harshavardhana
merged 6 commits into
minio:master
from
dhughesni:helm-gcs-gateway-config
Dec 15, 2021
Merged
Helm gcs gateway support #13810
harshavardhana
merged 6 commits into
minio:master
from
dhughesni:helm-gcs-gateway-config
Dec 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/helm/charts/tree/master/stable/minio Added `gcs` support for gateway mode. Added new gcs block under the gateway key to house the gcs specific variables. The gateway-deployment template now sets the env var: GOOGLE_APPLICATION_CREDENTIALS as a path to the gcs_key.json The gcs_key.json can be added to the minio secret if an existingSecret is not specified.
Is this still draft @dhughesni ? |
@harshavardhana Yes still a draft atm. |
@harshavardhana PR is ready for review - please let me know if there are any further actions required from me. |
harshavardhana
requested changes
Dec 15, 2021
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
harshavardhana
approved these changes
Dec 15, 2021
Mint Automation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gcs
support for gateway mode.Motivation and Context
gcs
. We need the ability to deploy minio as a gcs gateway via helm.How to test this PR?
modify values for gcs gateway deployment
debug install as dry-run to check entrypoint is configured correctly
test chart install
Types of changes
Checklist:
commit-id
orPR #
here)