New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
honor canceled context and do not leak on mergeChannels #15034
Merged
harshavardhana
merged 1 commit into
minio:master
from
harshavardhana:remove-potential-leaks
Jun 3, 2022
Merged
honor canceled context and do not leak on mergeChannels #15034
harshavardhana
merged 1 commit into
minio:master
from
harshavardhana:remove-potential-leaks
Jun 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
remove-potential-leaks
branch
from
June 3, 2022 04:22
654bd37
to
1c2d5ed
Compare
mergeEntryChannels has the potential to perpetually wait on the results channel, context might be closed and we did not honor the caller context canceling.
harshavardhana
force-pushed
the
remove-potential-leaks
branch
from
June 3, 2022 04:22
1c2d5ed
to
3611125
Compare
Mint Automation
15034-3611125/mint-dist-erasure.sh.log:
Deleting image on docker hub |
klauspost
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
vadmeste
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vadmeste
pushed a commit
to vadmeste/minio
that referenced
this pull request
Dec 12, 2022
mergeEntryChannels has the potential to perpetually wait on the results channel, context might be closed and we did not honor the caller context canceling.
harshavardhana
added a commit
that referenced
this pull request
Mar 6, 2023
mergeEntryChannels has the potential to perpetually wait on the results channel, context might be closed and we did not honor the caller context canceling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
honor canceled context and do not leak on mergeChannels
Motivation and Context
mergeEntryChannels has the potential to perpetually
wait on the results channel, context might be closed
and we did not honor the caller context canceling.
How to test this PR?
Not sure, but it looks like reproduced here #15033
Types of changes
Checklist:
commit-id
orPR #
here)