Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass multiple IDP config to console #15270

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

donatello
Copy link
Member

Description

This change passes sending configuration of all configured IDPs to console via a struct.

This change only changes the method of passing configuration to console and passes all enabled IDPs to console - further work is needed for integrating multiple IDPs in the web UI.

Motivation and Context

This change allows us to integrate multiple IDPs in the web console in subsequent changes.

How to test this PR?

Existing functionality should be preserved - i.e. a single IDP should continue to work as-is with this change.

Run make podman-run from https://github.com/minio/minio-iam-testing to start testing IDP services.

Start minio with console on port 10000.

# Configure IDP as claim based provider (needs latest mc at time of writing)
$ mc admin idp set myminio openid     config_url="http://localhost:5557/dex/.well-known/openid-configuration"     client_id="minio-client-app-2"     client_secret="minio-client-app-secret-2"     scopes="openid,groups"     redirect_uri="http://127.0.0.1:10000/oauth_callback"     display_name="Login via dex2"     role_policy='' claim_name=groups

Now attempt to login normally via console (dillon@example.io and dillon as password).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@donatello
Copy link
Member Author

Needs minio/console#2167

@donatello
Copy link
Member Author

This is ready, but needs go.mod update.

@donatello
Copy link
Member Author

This needs to be merged in-sync with the next console release.

cmd/common-main.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@harshavardhana
Copy link
Member

PTAL @donatello

This change passes multiple IDP config via a struct rather than env
variables.
@donatello
Copy link
Member Author

Updated to depend on current console master.

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit 39fd7b0 into minio:master Jul 22, 2022
@donatello donatello deleted the openid-console branch July 24, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants