Skip to content
This repository was archived by the owner on Mar 20, 2026. It is now read-only.

Release v4.4.26#1210

Merged
harshavardhana merged 1 commit intominio:masterfrom
dvaldivia:release-v4.4.26
Jul 20, 2022
Merged

Release v4.4.26#1210
harshavardhana merged 1 commit intominio:masterfrom
dvaldivia:release-v4.4.26

Conversation

@dvaldivia
Copy link
Copy Markdown
Collaborator

Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com

cniackz
cniackz previously approved these changes Jul 19, 2022
Copy link
Copy Markdown
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Daniel :)

bexsoft
bexsoft previously approved these changes Jul 19, 2022
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@dvaldivia dvaldivia dismissed stale reviews from cniackz and bexsoft via 3a8e44c July 19, 2022 16:34
@cniackz cniackz self-requested a review July 19, 2022 16:34
Copy link
Copy Markdown
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donatello
Copy link
Copy Markdown
Member

donatello commented Jul 19, 2022

Noting that minio/minio#15270 needs to go in as soon as this is merged to avoid OpenID related breakage.

@harshavardhana
Copy link
Copy Markdown
Member

Noting that minio/minio#15270 needs to go in as soon as this is merged to avoid OpenID related breakage.

what will break? @donatello

@donatello
Copy link
Copy Markdown
Member

donatello commented Jul 19, 2022

what will break? @donatello

@harshavardhana MinIO needs that change, so console will work with OpenID as expected (for a single claim based provider), because we have changed the way console receives the openid config.

Oops that's for console release, not operator, my bad.

@harshavardhana harshavardhana merged commit fee3007 into minio:master Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants