Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: add cilium networkpolicy #18650

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

QuantumEnigmaa
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

his PR adds a ciliumnetworkpolicy that is equivalent to the standard networkpolicy already present in the templates. As cilium usage as a CNI is rising and the usage of ciliumnetworkpolicies is more and more widespread, having the possibility to deploy those directly from a setting in the values would be a time-saving option for a lot of deployments.

As this PR adds a new condition for the already existing networkpolicy, this is a breaking change for those using the chart with networkpolicies enabled as they'll have to add the new field to their values file.

Motivation and Context

As I tried to use minio alongside loki on a cluster which was using cilium as its CNI, the minio pod was not able to work properly. Especially the job supposed to interact with the main minio pod was not able to complete so I had to manually create a cilium netpol.

How to test this PR?

One may ltemplate the chart or even deploy it to a cluster with cilium as the CNI to make sure the pod is running as expected and the job is able to complete.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
Signed-off-by: QuantumEnigmaa <thibaud@giantswarm.io>
@QuantumEnigmaa
Copy link
Contributor Author

Should I also bump the chart version ?

@QuantumEnigmaa
Copy link
Contributor Author

@harshavardhana @vadmeste Could you please take a look ?

@harshavardhana harshavardhana merged commit 8273957 into minio:master Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants