Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line, col to types used in batch-expire #18747

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

krisis
Copy link
Member

@krisis krisis commented Jan 6, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Batch jobs feature require users to write yaml files to configure different job parameters. With this change, batch job validation errors would provides location hints (line number, column number) for the validation error.

Sample output

$ mc batch start myminio ./expire.yaml
mc: <ERROR> Unable to start job. We encountered an internal error, please try again.: cause(Invalid batch expire rule: key can't be empty
 Hint: error near line: 24, col: 11).
...
      metadata:
        - key: 
          value: application/* # match objects with 'content-type', all values starting with 'image/'
 

Motivation and Context

To simplify debugging of minor typos in the context of batch job yamls.

How to test this PR?

mc batch start ALIAS job.yaml, with a few typos for taste.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@krisis krisis force-pushed the batch-yaml-errs branch 2 times, most recently from 720166e to 98e6564 Compare January 8, 2024 19:32
@krisis krisis marked this pull request as ready for review January 8, 2024 20:32
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 3a90af0 into minio:master Jan 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants