Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Add apiVersion and kind to the StatefulSets volumeClaimTemplates #18770

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

ItsKev
Copy link
Contributor

@ItsKev ItsKev commented Jan 10, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

The Minio Helm chart, when set up in its default "distributed" mode, generates a StatefulSet with two volumeClaimTemplates. When you deploy this Helm chart via ArgoCD it continually shows as out of sync because the apiVersion and kind are missing in those volumeClaimTemplates.

image

Motivation and Context

We would like to have a proper "Synced" state in ArgoCD.

How to test this PR?

Deploy a minio instance with using ArgoCD and the minio Helm chart.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@thomaspetit
Copy link
Contributor

thomaspetit commented Jan 10, 2024

@ItsKev there is a technical work-around for ArgoCD, ignore this block:

https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/values.yaml#L153

configs:
  cm:
    resource.customizations.ignoreDifferences.apps_StatefulSet: |
      jsonPointers:
      - /spec/template/spec/volumes
      jqPathExpressions:
      - '.spec.volumeClaimTemplates[].apiVersion'
      - '.spec.volumeClaimTemplates[].kind'

I've made already a similar PR for Vault hashicorp/vault-helm#982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants