update() stale rebalance stats() object during pool expansion #18882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
added
priority: high
next-release
harshavardhana
force-pushed
the
fix-rebalance
branch
from
0a73f50
to
9a7e702
Compare
it is entirely possible that a rebalance process which was running when it was asked to "stop" it failed to write its last statistics to the disk. After this a pool expansion can cause disruption and all S3 API calls would fail at IsPoolRebalancing() function. This PRs makes sure that we update rebalance.bin under such conditions to avoid any runtime crashes.
harshavardhana
force-pushed
the
fix-rebalance
branch
from
9a7e702
to
b9b0745
Compare
kannappanr
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
update() stale rebalance stats() object during pool expansion
Motivation and Context
it is entirely possible that a rebalance process that was
running when it was asked to "stop" it failed to write its
last statistics to the disk.
After this, a pool expansion can cause disruption, and all
S3 API calls would fail at the IsPoolRebalancing() function.
This PR makes sure that we update rebalance.bin under
such conditions to avoid any runtime crashes.
How to test this PR?
You need to introduce situations of a bit of instability on
the cluster when rebalance fails to save its statistics.
There is a customer who seems to have faced this problem.
Types of changes
Checklist:
commit-idorPR #here)