Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore x-amz-storage-class when its set to STANDARD #19154

Merged
merged 1 commit into from Feb 29, 2024
Merged

ignore x-amz-storage-class when its set to STANDARD #19154

merged 1 commit into from Feb 29, 2024

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

ignore x-amz-storage-class when it's set to STANDARD

Motivation and Context

fixes #19135

How to test this PR?

As per #19135 - needs that specific data set

Types of changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana
Copy link
Member Author

This header is never sent to client if set to "STANDARD" - no point populating it in the first place for metadata lookups.

@harshavardhana harshavardhana merged commit 467714f into minio:master Feb 29, 2024
20 checks passed
@harshavardhana harshavardhana deleted the fix-healing branch February 29, 2024 01:44
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Feb 29, 2024
@harshavardhana
fix: relax metadata checks for healing
e4c12fe 
we should do this to ensure that we focus on
data healing as primary focus, fixing metadata
as part of healing must be done but making
data available is the main focus.

the main reason is metadata inconsistencies can
cause data availability issues, which must be
avoided at all cost.

will be bringing in an additional healing mechanism
that involves "metadata-only" heal, for now we do
not expect to have these checks.

continuation of minio#19154
@harshavardhana harshavardhana mentioned this pull request Feb 29, 2024
Merged
8 tasks
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Feb 29, 2024
@harshavardhana
fix: relax metadata checks for healing
2c70a6f 
we should do this to ensure that we focus on
data healing as primary focus, fixing metadata
as part of healing must be done but making
data available is the main focus.

the main reason is metadata inconsistencies can
cause data availability issues, which must be
avoided at all cost.

will be bringing in an additional healing mechanism
that involves "metadata-only" heal, for now we do
not expect to have these checks.

continuation of minio#19154
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Feb 29, 2024
@harshavardhana
fix: relax metadata checks for healing
c9b8e40 
we should do this to ensure that we focus on
data healing as primary focus, fixing metadata
as part of healing must be done but making
data available is the main focus.

the main reason is metadata inconsistencies can
cause data availability issues, which must be
avoided at all cost.

will be bringing in an additional healing mechanism
that involves "metadata-only" heal, for now we do
not expect to have these checks.

continuation of minio#19154
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Mar 1, 2024
@harshavardhana
fix: relax metadata checks for healing
1d3a25b 
we should do this to ensure that we focus on
data healing as primary focus, fixing metadata
as part of healing must be done but making
data available is the main focus.

the main reason is metadata inconsistencies can
cause data availability issues, which must be
avoided at all cost.

will be bringing in an additional healing mechanism
that involves "metadata-only" heal, for now we do
not expect to have these checks.

continuation of minio#19154
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Mar 1, 2024
@harshavardhana
fix: relax metadata checks for healing
b5bcbba 
we should do this to ensure that we focus on
data healing as primary focus, fixing metadata
as part of healing must be done but making
data available is the main focus.

the main reason is metadata inconsistencies can
cause data availability issues, which must be
avoided at all cost.

will be bringing in an additional healing mechanism
that involves "metadata-only" heal, for now we do
not expect to have these checks.

continuation of minio#19154

Bonus: add a pro-active healthcheck to perform a connection
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Mar 1, 2024
@harshavardhana
fix: relax metadata checks for healing
b9495fc 
we should do this to ensure that we focus on
data healing as primary focus, fixing metadata
as part of healing must be done but making
data available is the main focus.

the main reason is metadata inconsistencies can
cause data availability issues, which must be
avoided at all cost.

will be bringing in an additional healing mechanism
that involves "metadata-only" heal, for now we do
not expect to have these checks.

continuation of minio#19154

Bonus: add a pro-active healthcheck to perform a connection
harshavardhana added a commit that referenced this pull request Mar 1, 2024
@harshavardhana
fix: relax metadata checks for healing (#19165)
c599c11 
we should do this to ensure that we focus on
data healing as primary focus, fixing metadata
as part of healing must be done but making
data available is the main focus.

the main reason is metadata inconsistencies can
cause data availability issues, which must be
avoided at all cost.

will be bringing in an additional healing mechanism
that involves "metadata-only" heal, for now we do
not expect to have these checks.

continuation of #19154

Bonus: add a pro-active healthcheck to perform a connection
kanagarajkm pushed a commit that referenced this pull request Mar 30, 2024
@harshavardhana
fix: relax metadata checks for healing (#19165)
40d580a 
we should do this to ensure that we focus on
data healing as primary focus, fixing metadata
as part of healing must be done but making
data available is the main focus.

the main reason is metadata inconsistencies can
cause data availability issues, which must be
avoided at all cost.

will be bringing in an additional healing mechanism
that involves "metadata-only" heal, for now we do
not expect to have these checks.

continuation of #19154

Bonus: add a pro-active healthcheck to perform a connection
kanagarajkm pushed a commit that referenced this pull request Mar 30, 2024
@harshavardhana
ignore x-amz-storage-class when its set to STANDARD (#19154)
a1b88c6 
fixes #19135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas approved these changes

@jiuker jiuker jiuker approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"file version not found" during healing
3 participants
@harshavardhana @poornas @jiuker