fix: relax metadata checks for healing #19165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
relax-metadata
branch
2 times, most recently
from
2c70a6f
to
c9b8e40
Compare
poornas
approved these changes
Mar 1, 2024
harshavardhana
force-pushed
the
relax-metadata
branch
from
c9b8e40
to
1d3a25b
Compare
harshavardhana
force-pushed
the
relax-metadata
branch
from
1d3a25b
to
b5bcbba
Compare
we should do this to ensure that we focus on data healing as primary focus, fixing metadata as part of healing must be done but making data available is the main focus. the main reason is metadata inconsistencies can cause data availability issues, which must be avoided at all cost. will be bringing in an additional healing mechanism that involves "metadata-only" heal, for now we do not expect to have these checks. continuation of minio#19154 Bonus: add a pro-active healthcheck to perform a connection
harshavardhana
force-pushed
the
relax-metadata
branch
from
b5bcbba
to
b9495fc
Compare
shtripat
approved these changes
Mar 1, 2024
kanagarajkm
pushed a commit
that referenced
this pull request
Mar 30, 2024
we should do this to ensure that we focus on data healing as primary focus, fixing metadata as part of healing must be done but making data available is the main focus. the main reason is metadata inconsistencies can cause data availability issues, which must be avoided at all cost. will be bringing in an additional healing mechanism that involves "metadata-only" heal, for now we do not expect to have these checks. continuation of #19154 Bonus: add a pro-active healthcheck to perform a connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
fix: relax metadata checks for healing
Motivation and Context
we should do this to ensure that we focus on
data healing as the primary requirement, fixing
metadata as part of healing must be done, but
making data available is the main focus.
the main reason is metadata inconsistencies can
cause data availability issues, which must be
avoided at all costs.
will be bringing in an additional healing mechanism
that involves "metadata-only" healing, for now we do
not expect to have these checks.
continuation of #19154
How to test this PR?
As per #19154
Types of changes
Checklist:
commit-idorPR #here)