Remove pre go1.8 code and cleanup #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
remove
branch
from
1d73d1f
to
fe700dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #4933 +/- ##
==========================================
- Coverage 62.45% 62.43% -0.02%
==========================================
Files 193 193
Lines 27641 27619 -22
==========================================
- Hits 17262 17244 -18
+ Misses 9147 9144 -3
+ Partials 1232 1231 -1
Continue to review full report at Codecov.
|
vadmeste
reviewed
Sep 18, 2017
cmd/notify-webhook.go
Outdated
| if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusNoContent { | ||
| return fmt.Errorf("Unable to lookup webhook endpoint %s response(%s)", urlStr, resp.Status) | ||
| } | ||
| return resp.Body.Close() |
There was a problem hiding this comment.
Shouldn't we also close resp.Body when status code != 2xx ?
There was a problem hiding this comment.
We could potentially do that..
harshavardhana
force-pushed
the
remove
branch
from
fe700dd
to
1d9b1c8
Compare
We don't need certain go1.7.x custom code anymore, since we have migrated to go1.8
harshavardhana
force-pushed
the
remove
branch
from
1d9b1c8
to
827f211
Compare
deekoder
requested review from
balamurugana
and removed request for
deekoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need certain go1.7.x custom code anymore, since
we have migrated to go1.8
Description
Remove pre go1.8 code and cleanup
Motivation and Context
Migrate to go1.8 cleanup.
How Has This Been Tested?
Manually
Types of changes
Checklist: