Add missing healthcheck router for gateway #5764
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5764 +/- ##
=========================================
- Coverage 60.6% 60.6% -0.01%
=========================================
Files 196 196
Lines 29098 29036 -62
=========================================
- Hits 17635 17597 -38
+ Misses 9960 9937 -23
+ Partials 1503 1502 -1
Continue to review full report at Codecov.
|
Mint Automation
|
| @@ -57,6 +57,43 @@ func registerDistXLRouters(mux *router.Router, endpoints EndpointList) error { | |||
| return registerBrowserPeerRPCRouter(mux) | |||
| } | |||
|
|
|||
| // List of some generic handlers which are applied for all incoming requests. | |||
| var globalHandlers = []HandlerFunc{ | |||
There was a problem hiding this comment.
How about moving the globalHandlers var to globals.go
There was a problem hiding this comment.
not kept there on purpose @nitisht since routers.go is where we need to eventually converge.
There was a problem hiding this comment.
new handlers should be added here not in globals.go, a global entity is simply added for common usage it can be passed in as a value commonly. but can be perhaps moved to common-main.go
Description
Add missing healthcheck router for gateway
Motivation and Context
Missing healthcheck router
How Has This Been Tested?
Manually
Types of changes
Checklist:
mintPR # here: )