Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return bucketNameInvalid properly in B2 gateway #5787

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Apr 8, 2018

Description

Return bucketNameInvalid properly in B2 gateway

Motivation and Context

Fixes #5758

How Has This Been Tested?

Manually using B2 gateway

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@balamurugana
Copy link
Member

Error running mint automation
+ mkdir -p 5787-62f5be5/gopath/src/github.com/minio
+ git -C 5787-62f5be5/gopath/src/github.com/minio clone --quiet https://github.com/minio/minio.git
+ git -C 5787-62f5be5/gopath/src/github.com/minio/minio remote add minio https://github.com/minio/minio.git
+ git -C 5787-62f5be5/gopath/src/github.com/minio/minio fetch --quiet minio pull/5787/head:pr5787
+ git -C 5787-62f5be5/gopath/src/github.com/minio/minio checkout --quiet pr5787
+ GOPATH=/home/bala/mintauto/5787-62f5be5/gopath
+ make -C 5787-62f5be5/gopath/src/github.com/minio/minio --quiet
make: *** [checks] Error 1

@codecov
Copy link

codecov bot commented Apr 8, 2018

Codecov Report

Merging #5787 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5787      +/-   ##
==========================================
- Coverage    59.8%   59.77%   -0.04%     
==========================================
  Files         194      194              
  Lines       29517    29524       +7     
==========================================
- Hits        17653    17647       -6     
- Misses      10359    10373      +14     
+ Partials     1505     1504       -1
Impacted Files Coverage Δ
cmd/gateway/b2/gateway-b2.go 17.63% <0%> (-0.28%) ⬇️
cmd/retry.go 82.75% <0%> (-5.18%) ⬇️
cmd/xl-v1-common.go 95.34% <0%> (-4.66%) ⬇️
cmd/xl-sets.go 57.99% <0%> (-0.42%) ⬇️
cmd/fs-v1-rwpool.go 65.81% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650c6ee...c467452. Read the comment docs.

nitisht
nitisht previously approved these changes Apr 10, 2018
@harshavardhana
Copy link
Member Author

@nitisht @krishnasrinivas PTAL

@balamurugana
Copy link
Member

Mint Automation

Test Result
mint-xl.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh more...

5787-c467452/mint-gateway-azure.sh.log:

Running with
SERVER_ENDPOINT: minikube:30573
ACCESS_KEY:      minioazure1
SECRET_KEY:      ***REDACTED***
ENABLE_HTTPS:    0
SERVER_REGION:   us-east-1
MINT_DATA_DIR:   /mint/data
MINT_MODE:       core

To get logs, run 'docker cp c0c6ac9e57d1:/mint/log /tmp/mint-logs'
(1/12) Running aws-sdk-go tests ... done in 1 seconds
(2/12) Running aws-sdk-php tests ... done in 7 minutes and 54 seconds
(3/12) Running aws-sdk-ruby tests ... done in 42 seconds
(4/12) Running awscli tests ... done in 4 minutes and 2 seconds
(5/12) Running mc tests ... done in 7 minutes and 34 seconds
(6/12) Running minio-dotnet tests ... done in 1 minutes and 9 seconds
(7/12) Running minio-go tests ... done in 1 seconds
(8/12) Running minio-java tests ... done in 35 seconds
(9/12) Running minio-js tests ... FAILED in 2 minutes and 49 seconds
{
  "name": "minio-js",
  "function": "getBucketPolicy(bucketName, cb)",
  "args": "bucketName:minio-js-test-f697918d-bdc9-4d53-8e69-822303ff1da0",
  "duration": 278,
  "status": "FAIL",
  "error": "S3Error: The bucket policy does not exist at Object.parseError (node_modules/minio/dist/main/xml-parsers.js:56:11) at /mint/run/core/minio-js/node_modules/minio/dist/main/transformers.js:117:22 at DestroyableTransform._flush (node_modules/minio/dist/main/transformers.js:48:26) at DestroyableTransform.<anonymous> (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:135:12) at finishMaybe (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:371:12) at endWritable (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:378:3) at DestroyableTransform.Writable.end (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:356:5) at IncomingMessage.onend (_stream_readable.js:511:10) at endReadableNT (_stream_readable.js:974:12) at _combinedTickCallback (internal/process/next_tick.js:80:11) at process._tickCallback (internal/process/next_tick.js:104:9)"
}

Executed 8 out of 12 tests successfully.

@nitisht nitisht merged commit bd8d6e3 into minio:master Apr 12, 2018
@harshavardhana harshavardhana deleted the fix-b2 branch April 12, 2018 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

b2 gateway gives misleading error messages for "mc mb" failures
4 participants