Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup help to bring concise self-help message #5788

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Apr 8, 2018

Description

Cleanup help to bring concise self-help message

Motivation and Context

Cleanup

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@balamurugana
Copy link
Member

Error running mint automation
+ mkdir -p 5788-05ff080/gopath/src/github.com/minio
+ git -C 5788-05ff080/gopath/src/github.com/minio clone --quiet https://github.com/minio/minio.git
+ git -C 5788-05ff080/gopath/src/github.com/minio/minio remote add minio https://github.com/minio/minio.git
+ git -C 5788-05ff080/gopath/src/github.com/minio/minio fetch --quiet minio pull/5788/head:pr5788
+ git -C 5788-05ff080/gopath/src/github.com/minio/minio checkout --quiet pr5788
+ GOPATH=/home/bala/mintauto/5788-05ff080/gopath
+ make -C 5788-05ff080/gopath/src/github.com/minio/minio --quiet
make: *** [checks] Error 1

nitisht
nitisht previously approved these changes Apr 8, 2018
@codecov
Copy link

codecov bot commented Apr 8, 2018

Codecov Report

Merging #5788 into master will increase coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5788      +/-   ##
==========================================
+ Coverage   59.79%   59.93%   +0.14%     
==========================================
  Files         194      194              
  Lines       29531    29660     +129     
==========================================
+ Hits        17657    17776     +119     
- Misses      10371    10381      +10     
  Partials     1503     1503
Impacted Files Coverage Δ
cmd/server-main.go 13.81% <ø> (ø) ⬆️
cmd/gateway/sia/gateway-sia.go 13.47% <0%> (-0.05%) ⬇️
cmd/gateway-main.go 22.79% <0%> (ø) ⬆️
cmd/xl-sets.go 58.33% <0%> (+0.41%) ⬆️
cmd/generic-handlers.go 78% <0%> (+0.6%) ⬆️
cmd/prepare-storage.go 35.08% <0%> (+1.3%) ⬆️
cmd/routers.go 53.7% <0%> (+2.68%) ⬆️
cmd/format-xl.go 76.25% <0%> (+4.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39de65...2192186. Read the comment docs.

@balamurugana
Copy link
Member

Error running mint automation
+ mkdir -p 5788-3fdd7db/gopath/src/github.com/minio
+ git -C 5788-3fdd7db/gopath/src/github.com/minio clone --quiet https://github.com/minio/minio.git
+ git -C 5788-3fdd7db/gopath/src/github.com/minio/minio remote add minio https://github.com/minio/minio.git
+ git -C 5788-3fdd7db/gopath/src/github.com/minio/minio fetch --quiet minio pull/5788/head:pr5788
+ git -C 5788-3fdd7db/gopath/src/github.com/minio/minio checkout --quiet pr5788
+ GOPATH=/home/bala/mintauto/5788-3fdd7db/gopath
+ make -C 5788-3fdd7db/gopath/src/github.com/minio/minio --quiet
make: *** [checks] Error 1

nitisht
nitisht previously approved these changes Apr 10, 2018
@harshavardhana
Copy link
Member Author

@krisis @nitisht PTAL

@balamurugana
Copy link
Member

Mint Automation

Test Result
mint-xl.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh more...

5788-111090e/mint-gateway-azure.sh.log:

Running with
SERVER_ENDPOINT: minikube:31276
ACCESS_KEY:      minioazure1
SECRET_KEY:      ***REDACTED***
ENABLE_HTTPS:    0
SERVER_REGION:   us-east-1
MINT_DATA_DIR:   /mint/data
MINT_MODE:       core

To get logs, run 'docker cp 887b7718d818:/mint/log /tmp/mint-logs'
(1/12) Running aws-sdk-go tests ... done in 1 seconds
(2/12) Running aws-sdk-php tests ... done in 8 minutes and 5 seconds
(3/12) Running aws-sdk-ruby tests ... done in 52 seconds
(4/12) Running awscli tests ... done in 3 minutes and 52 seconds
(5/12) Running mc tests ... done in 8 minutes and 2 seconds
(6/12) Running minio-dotnet tests ... done in 1 minutes and 5 seconds
(7/12) Running minio-go tests ... done in 2 seconds
(8/12) Running minio-java tests ... done in 35 seconds
(9/12) Running minio-js tests ... FAILED in 2 minutes and 45 seconds
{
  "name": "minio-js",
  "function": "getBucketPolicy(bucketName, cb)",
  "args": "bucketName:minio-js-test-d1a50584-2402-44c9-bdbf-4065d9bc4ca2",
  "duration": 260,
  "status": "FAIL",
  "error": "S3Error: The bucket policy does not exist at Object.parseError (node_modules/minio/dist/main/xml-parsers.js:56:11) at /mint/run/core/minio-js/node_modules/minio/dist/main/transformers.js:117:22 at DestroyableTransform._flush (node_modules/minio/dist/main/transformers.js:48:26) at DestroyableTransform.<anonymous> (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:135:12) at finishMaybe (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:371:12) at endWritable (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:378:3) at DestroyableTransform.Writable.end (node_modules/minio/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:356:5) at IncomingMessage.onend (_stream_readable.js:511:10) at endReadableNT (_stream_readable.js:974:12) at _combinedTickCallback (internal/process/next_tick.js:80:11) at process._tickCallback (internal/process/next_tick.js:104:9)"
}

Executed 8 out of 12 tests successfully.

nitisht
nitisht previously approved these changes Apr 12, 2018

logger.StartupMessage(colorBlue("\nSia Configuration:"))
logger.StartupMessage(colorBlue(" API Address:") + colorBold(fmt.Sprintf(formatStr(len(sia.Address), 7), sia.Address)) + "\n")
logger.StartupMessage(colorBlue(" Staging Directory:") + colorBold(fmt.Sprintf(" %s", sia.TempDir)) + "\n")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is 7 arrived at? does it work for all terminal sizes?
Also, if there is only one place where formatStr is being called, can't we replace it with fmt.Sprintf("%ds", len(sia.Address), 7)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh we can I just generalized it. It works for most terminals starting from 80x25 . Its the same style used in our startup messages.

@harshavardhana
Copy link
Member Author

updated PTAL @krisis @nitisht

@kannappanr kannappanr merged commit 57b8db2 into minio:master Apr 13, 2018
@harshavardhana harshavardhana deleted the reduce-help branch April 13, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants