Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary logging for policy not found errors #6104

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Jun 29, 2018

Description

Avoid unnecessary logging for policy not found errors

Motivation and Context

Avoid unnecessary logging for policy not found errors

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #6104 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6104      +/-   ##
==========================================
+ Coverage   58.65%   58.66%   +<.01%     
==========================================
  Files         221      221              
  Lines       31751    31744       -7     
==========================================
- Hits        18624    18622       -2     
+ Misses      11474    11469       -5     
  Partials     1653     1653
Impacted Files Coverage Δ
cmd/gateway/s3/gateway-s3.go 20% <ø> (+0.08%) ⬆️
cmd/gateway/oss/gateway-oss.go 19.59% <ø> (+0.03%) ⬆️
cmd/gateway/gcs/gateway-gcs.go 20.26% <ø> (+0.08%) ⬆️
cmd/gateway/b2/gateway-b2.go 16.95% <ø> (+0.03%) ⬆️
cmd/gateway/azure/gateway-azure.go 25.22% <ø> (+0.03%) ⬆️
cmd/xl-sets.go 53.99% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53d511...21984b3. Read the comment docs.

@nitisht nitisht requested a review from kannappanr June 29, 2018 10:46
@minio-ops
Copy link

Mint Automation

Test Result
mint-gateway-s3.sh ✔️
mint-xl.sh ✔️
mint-gateway-nas.sh ✔️
mint-large-bucket.sh ✔️
mint-worm.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-azure.sh more...

6104-21984b3/mint-gateway-azure.sh.log:

Running with
SERVER_ENDPOINT:      minikube:32643
ACCESS_KEY:           minioazure1
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 01ce01a67d5b:/mint/log /tmp/mint-logs'
(1/13) Running awscli tests ... FAILED in 21 seconds
{
  "name": "awscli",
  "duration": 6131,
  "function": "make_bucket\n",
  "status": "FAIL",
  "error": "An error occurred (InternalError) when calling the CreateBucket operation (reached max retries: 4): We encountered an internal error, please try again."
}

Executed 0 out of 13 tests successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants