Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update KMS README.md to set approle env #6978

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Dec 14, 2018

Description

README is missing settings for MINIO_SSE_VAULT_AUTH_TYPE

Motivation and Context

for usability

Regression

No

How Has This Been Tested?

  • follow kms settings in readme and minio server should start up with vault enabled.
    aws s3api put-object --bucket testb1 --key s3copy/a/b/c --body /tmp/smallfile --endpoint-url http://localhost:9000 --server-side-encryption AES256
    should create the object

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minio-ops
Copy link

Mint Automation

Test Result
mint-tls.sh ✔️
mint-compression-xl.sh ✔️
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-compression-fs.sh ✔️
mint-worm.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️

@kannappanr kannappanr self-requested a review December 14, 2018 21:25
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #6978 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6978      +/-   ##
==========================================
+ Coverage   52.22%   52.23%   +0.01%     
==========================================
  Files         271      271              
  Lines       42752    42752              
==========================================
+ Hits        22326    22331       +5     
+ Misses      18440    18437       -3     
+ Partials     1986     1984       -2
Impacted Files Coverage Δ
cmd/posix.go 68.88% <0%> (+0.35%) ⬆️
cmd/fs-v1-helpers.go 68.8% <0%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bebaff2...6a2e0e3. Read the comment docs.

@kannappanr kannappanr merged commit 13cb814 into minio:master Dec 14, 2018
richardkiene pushed a commit to richardkiene/minio that referenced this pull request Jan 2, 2019
richardkiene pushed a commit to richardkiene/minio that referenced this pull request Jan 2, 2019
@poornas poornas deleted the dfix branch January 10, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants