Add more information in our select docs #7177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7177 +/- ##
==========================================
+ Coverage 49.27% 49.29% +0.01%
==========================================
Files 288 288
Lines 44971 44971
==========================================
+ Hits 22161 22168 +7
+ Misses 20782 20778 -4
+ Partials 2028 2025 -3
Continue to review full report at Codecov.
|
donatello
requested changes
Feb 1, 2019
donatello
requested changes
Feb 1, 2019
donatello
previously approved these changes
Feb 1, 2019
eco-minio
requested changes
Feb 1, 2019
docs/select/README.md
Outdated
| - Large numbers (more than 64-bit) are not yet supported | ||
| - Date related functions are not yet supported (EXTRACT, DATE_DIFF, etc) | ||
| - S3's reserved keywords list is not yet respected | ||
| Type inference and automatic conversion of values is performed based on the context when the value is un-typed (such as when reading CSV data). CAST function if present overrides automatic conversion. |
There was a problem hiding this comment.
For any reference to any API, or function of an API, should we be using a format like CAST or Select, or will regular formatting will suffice?
There was a problem hiding this comment.
This is a select doc so it refers to only select, I don't think we need to be explicit about. Since the context is implicit.
|
@donatello @eco-minio PTAL |
|
Changed strings to string PTAL @eco-minio @donatello |
donatello
approved these changes
Feb 1, 2019
Mint Automation
|
eco-minio
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more information in our select docs
Motivation and Context
Adding more details about our implementation
Regression
No
How Has This Been Tested?
Just documentation changes, need to be proof read.
Types of changes
Checklist:
mintPR # here: )