Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information in our select docs #7177

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

harshavardhana
Copy link
Member

Description

Add more information in our select docs

Motivation and Context

Adding more details about our implementation

Regression

No

How Has This Been Tested?

Just documentation changes, need to be proof read.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #7177 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7177      +/-   ##
==========================================
+ Coverage   49.27%   49.29%   +0.01%     
==========================================
  Files         288      288              
  Lines       44971    44971              
==========================================
+ Hits        22161    22168       +7     
+ Misses      20782    20778       -4     
+ Partials     2028     2025       -3
Impacted Files Coverage Δ
cmd/posix-list-dir_unix.go 72.36% <0%> (-2.64%) ⬇️
cmd/fs-v1.go 64.33% <0%> (+0.11%) ⬆️
cmd/posix.go 65.27% <0%> (+0.21%) ⬆️
cmd/bitrot-streaming.go 81.55% <0%> (+2.91%) ⬆️
cmd/posix-list-dir_windows.go 64.7% <0%> (+4.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de2c106...e7ef811. Read the comment docs.

docs/select/README.md Outdated Show resolved Hide resolved
docs/select/README.md Outdated Show resolved Hide resolved
donatello
donatello previously approved these changes Feb 1, 2019
docs/select/README.md Outdated Show resolved Hide resolved
docs/select/README.md Outdated Show resolved Hide resolved
docs/select/README.md Outdated Show resolved Hide resolved
docs/select/README.md Outdated Show resolved Hide resolved
docs/select/README.md Outdated Show resolved Hide resolved
- Large numbers (more than 64-bit) are not yet supported
- Date related functions are not yet supported (EXTRACT, DATE_DIFF, etc)
- S3's reserved keywords list is not yet respected
Type inference and automatic conversion of values is performed based on the context when the value is un-typed (such as when reading CSV data). CAST function if present overrides automatic conversion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any reference to any API, or function of an API, should we be using a format like CAST or Select, or will regular formatting will suffice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a select doc so it refers to only select, I don't think we need to be explicit about. Since the context is implicit.

docs/select/README.md Outdated Show resolved Hide resolved
docs/select/README.md Outdated Show resolved Hide resolved
docs/select/README.md Outdated Show resolved Hide resolved
@harshavardhana
Copy link
Member Author

@donatello @eco-minio PTAL

eco-minio
eco-minio previously approved these changes Feb 1, 2019
Copy link
Contributor

@eco-minio eco-minio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana
Copy link
Member Author

Changed strings to string PTAL @eco-minio @donatello

@minio-ops
Copy link

Mint Automation

Test Result
mint-tls.sh ✔️
mint-compression-xl.sh ✔️
mint-xl.sh ✔️
mint-gateway-nas.sh ✔️
mint-large-bucket.sh ✔️
mint-compression-fs.sh ✔️
mint-worm.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️

@kannappanr kannappanr merged commit e005910 into minio:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants