-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the server to start if one of the local nodes in a swarm/kube setup shows up and successfully resolves. #7452
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7452 +/- ##
==========================================
+ Coverage 48% 48.02% +0.02%
==========================================
Files 296 296
Lines 46796 46828 +32
==========================================
+ Hits 22463 22490 +27
+ Misses 22247 22246 -1
- Partials 2086 2092 +6
Continue to review full report at Codecov.
|
8337fa4
to
7bb6014
Compare
6d7e018
to
0146a9d
Compare
…tes setup is successfully resolved - The rule is that we need atleast one local node to work. We dont need to resolve the rest at that point. - In a non-orchestrational setup, we fail if we do not have atleast one local node up and running. - In an orchestrational setup (docker-swarm and kubernetes), We retry with a sleep of 5 seconds until any one local node shows up. fixes minio#6995
7bb6014
to
6d5cfbe
Compare
Mint Automation
7452-6d5cfbe/mint-fs.sh.log:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
ping @balamurugana |
Description
The rule is that we need atleast one local node to work. We dont need to resolve the
rest at that point.
In a non-orchestrational setup, we fail if we do not have atleast one local node up
and running.
In an orchestrational setup (docker-swarm and kubernetes), We retry with a sleep of 5
seconds until any one local node shows up.
Motivation and Context
Minio should not halt the start-up in such occasions. fixes #6995
Regression
No
How Has This Been Tested?
docker stop <container-id>
mc admin service restart
Types of changes
Checklist:
mint
PR # here: )