[sec] Match ${aws:username} exactly instead of prefix match #7791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a high priority fix @aead @kannappanr and we need to make a security release. |
harshavardhana
force-pushed
the
fix-policy
branch
from
23b4e1f
to
eff12a2
Compare
This PR fixes a security issue where an IAM user based on his policy is granted more privileges than restricted by the users IAM policy. This is due to an issue of prefix based Matcher() function which was incorrectly matching prefix based on resource prefixes instead of exact match.
harshavardhana
force-pushed
the
fix-policy
branch
from
d105c89
to
3cffe20
Compare
Mint Automation
7791-eff12a2/mint-large-bucket.sh.log:7791-eff12a2/mint-dist-xl.sh.log:7791-eff12a2/mint-compression-fs.sh.log: |
krishnasrinivas
approved these changes
Jun 15, 2019
|
was doing some testing, there is some issue (might not be related to this fix): observe the entry: need to see how it can be reproduced |
This is already fixed @krishnasrinivas we made a release after this fix b4ab778 You are on old commits... |
Codecov Report
@@ Coverage Diff @@
## master #7791 +/- ##
=========================================
+ Coverage 45.89% 46.29% +0.4%
=========================================
Files 284 300 +16
Lines 48016 48359 +343
=========================================
+ Hits 22038 22390 +352
+ Misses 23910 23887 -23
- Partials 2068 2082 +14
Continue to review full report at Codecov.
|
aead
pushed a commit
that referenced
this pull request
Jun 17, 2019
This PR fixes a security issue where an IAM user based on his policy is granted more privileges than restricted by the users IAM policy. This is due to an issue of prefix based Matcher() function which was incorrectly matching prefix based on resource prefixes instead of exact match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[sec] Match ${aws:username} exactly instead of prefix match
Motivation and Context
This PR fixes a security issue where an IAM user based
on his policy is granted more privileges than restricted
by the users IAM policy.
This is due to an issue of prefix-based Matcher() function
which was incorrectly matching prefix based on resource
prefixes instead of an exact match.
Regression
No, this bug was introduced in IAM implementation PR 54ae364
How Has This Been Tested?
Using the following reproducer
usernamepolicy.json
{ "Version": "2012-10-17", "Statement": [ { "Effect": "Allow", "Principal": { "AWS": [ "*" ] }, "Action": [ "s3:GetBucketLocation", "s3:ListBucket", "s3:ListBucketMultipartUploads" ], "Resource": [ "arn:aws:s3:::${aws:username}" ] }, { "Effect": "Allow", "Principal": { "AWS": [ "*" ] }, "Action": [ "s3:AbortMultipartUpload", "s3:DeleteObject", "s3:GetObject", "s3:ListMultipartUploadParts", "s3:PutObject" ], "Resource": [ "arn:aws:s3:::${aws:username}/*" ] } ] }Types of changes
Checklist:
mintPR # here: )