-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safely use unsafe.Pointer to avoid crashes on ARM #8027
Conversation
db7f486
to
aae92bc
Compare
aae92bc
to
5df8177
Compare
By the way @harshavardhana, did you see in the original issue report any indication that there is an issue in dirent code ? |
Yes @vadmeste it happened every 12hrs which is our disk usage thread. |
ff6fa17
to
e567389
Compare
e567389
to
605678e
Compare
605678e
to
1f3cde6
Compare
Refactor the Dirent parsing code such that when we calculate offsets are correct based on the platform This PR fixes a silent potential crash on ARM architecture.
1f3cde6
to
cf64ea3
Compare
Mint Automation
8027-cf64ea3/mint-dist-xl.sh.log:
|
Codecov Report
@@ Coverage Diff @@
## master #8027 +/- ##
=========================================
- Coverage 44.35% 44.3% -0.06%
=========================================
Files 300 305 +5
Lines 51010 39699 -11311
=========================================
- Hits 22624 17587 -5037
+ Misses 26261 19976 -6285
- Partials 2125 2136 +11
Continue to review full report at Codecov.
|
ping @vadmeste |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & tested
Description
Safely use unsafe.Pointer to avoid crashes on ARM
Motivation and Context
Refactor the Dirent parsing code such that when we
calculate offsets are correct based on the platform
This PR fixes a silent potential crash on ARM
architecture.
Fixes #8005
How to test this PR?
You need access to ARM64 hardware as mentioned in issue #8005
Types of changes
Checklist:
commit-id
orPR #
here)