Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sdk-go: Bucket creation and server HTTPS endpoint setting is missing in PresignedPut test. #228

Closed
ebozduman opened this issue Nov 18, 2017 · 0 comments
Closed

aws-sdk-go: Bucket creation and server HTTPS endpoint setting is missing in PresignedPut test. #228

ebozduman opened this issue Nov 18, 2017 · 0 comments
Assignees
@kannappanr
Labels
fixed priority: high
Milestone
Current

Comments

@ebozduman
Copy link
Collaborator

ebozduman commented Nov 18, 2017 •
edited
Loading

  1. Bucket creation and clean-up (deletion) in the PresignedPut test run is missing.
  2. sdkEndpoint setting is missing the host info when secure option is turned on (environment variable ENABLE_HTTPS = 1)
endpoint := os.Getenv("SERVER_ENDPOINT")
accessKey := os.Getenv("ACCESS_KEY")
secretKey := os.Getenv("SECRET_KEY")
secure := os.Getenv("ENABLE_HTTPS")sdkEndpoint := "http://" + endpoint
if secure == "1" {
    sdkEndpoint = "https://"
}
@ebozduman ebozduman added this to the Current milestone Nov 18, 2017
kannappanr added a commit to kannappanr/mint that referenced this issue Nov 18, 2017
@kannappanr
Fix missing https endpoint name and added bucket creation/deletion
9948cba 
Added missing endpoint entry in the case of secure endpoint.
Added bucket creation and deletion code, as the error code is different
between AWS S3 and Minio server, if test is run with a non-existent bucket.

Fixes minio#228
@kannappanr kannappanr mentioned this issue Nov 18, 2017
Merged
kannappanr added a commit to kannappanr/mint that referenced this issue Nov 18, 2017
@kannappanr
Fix aws-sdk-go test behavior
83ba4e1 
Added missing endpoint entry in the case of secure endpoint.
Added bucket creation and deletion code, as the error code is different
between AWS S3 and Minio server, if test is run with a non-existent bucket.

Fixes minio#228
kannappanr added a commit to kannappanr/mint that referenced this issue Nov 18, 2017
@kannappanr
Fix aws-sdk-go test behavior
9c76045 
Added missing endpoint entry in the case of secure endpoint.
Added bucket creation and deletion code, as the error code is different
between AWS S3 and Minio server, if test is run with a non-existent bucket.

Fixes minio#228
harshavardhana pushed a commit that referenced this issue Nov 18, 2017
@kannappanr @harshavardhana
Fix aws-sdk-go test behavior (#229)
734b41f 
- Added missing endpoint entry in the case of secure endpoint.
- Added bucket creation and deletion code, as the error code is different 
  between AWS S3 and Minio server, if test is run with a non-existent bucket.

Fixes #228
kannappanr added a commit to kannappanr/mint that referenced this issue Nov 18, 2017
@kannappanr
Fix aws-sdk-go test behavior
18fa7fc 
Added missing endpoint entry in the case of secure endpoint.

Added bucket creation and deletion code, as the error code
is different between AWS S3 and Minio server, if test is run
with a non-existent bucket.

Added argument cleanup function

Added name of the test under test to the "name" field in the log.

Fixes minio#228
@ebozduman ebozduman changed the title aws-sdk-go: bucket creation and server endpoint setting for HTTPS is missing in PresignedPut test. aws-sdk-go: Bucket creation and server HTTPS endpoint setting is missing in PresignedPut test. Nov 18, 2017
@nitisht nitisht added the fixed label Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kannappanr kannappanr

Labels
fixed priority: high
Projects
None yet
Milestone
Current
Development

No branches or pull requests
3 participants
@nitisht @ebozduman @kannappanr