Fix aws-sdk-go test behavior #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannappanr
changed the title
kannappanr
force-pushed
the
aws_sdk_go_cleanup
branch
from
9948cba
to
83ba4e1
Compare
Added missing endpoint entry in the case of secure endpoint. Added bucket creation and deletion code, as the error code is different between AWS S3 and Minio server, if test is run with a non-existent bucket. Fixes minio#228
kannappanr
force-pushed
the
aws_sdk_go_cleanup
branch
from
83ba4e1
to
9c76045
Compare
ebozduman
requested changes
Nov 18, 2017
ebozduman
approved these changes
Nov 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing endpoint entry in the case of secure endpoint.
Added bucket creation and deletion code, as the error code is different
between AWS S3 and Minio server, if test is run with a non-existent bucket.
Fixes #228