Add test framework for mint #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tests for mc and general cleanup - clean up for minio-py
removing logging in python sdk
- Added documentation (#6)
harshavardhana
requested changes
Jun 14, 2017
apps/init/initCheck.go
Outdated
| @@ -24,9 +24,6 @@ import ( | |||
| ) | |||
|
|
|||
| func main() { | |||
| // obtain endpoint from env. | |||
| // it is set using `-e` when starting the container | |||
| // check README.md for instructions. | |||
| endpoint := os.Getenv("S3_ADDRESS") | |||
run.sh
Outdated
| # S3_ADDRESS is passed on as env variables while starting the docker container. | ||
| # see README.md for info on options. | ||
| # Note: https://play.minio.io hosts publicly available Minio server. | ||
| if [ -z "$S3_ADDRESS" ]; then |
| @@ -0,0 +1,69 @@ | |||
| #!/usr/bin/env bash | |||
| } | ||
|
|
||
| # invoke the script | ||
| main "$@" |
README.md
Outdated
| The project will be published in Docker hub after further more testing. Till then the docker image has to be built locally and run. | ||
|
|
||
| ### Build | ||
|
|
||
| ```sh | ||
| $ git clone https://github.com/minio/mint.git | ||
| $ cd mint | ||
| $ docker build -t minio/mint:alpha . | ||
| $ docker build -t minio/mint:mint . |
There was a problem hiding this comment.
Keep the image as latest minio/mint:latest
Dockerfile
Outdated
| go get -u github.com/minio/minio-go && \ | ||
| chmod +x run.sh | ||
|
|
||
| COPY . /mint |
There was a problem hiding this comment.
Keep two dockerfiles one more Dockerfile and another for release. Dockerfile.release
Dockerfile
Outdated
| default-jre \ | ||
| default-jdk \ | ||
| git \ | ||
| golang-go \ |
There was a problem hiding this comment.
go-1.6 version should be moved to go1.7
poornas
force-pushed
the
mint2
branch
2 times, most recently
from
324d647
to
10566c4
Compare
Dockerfile
Outdated
| mv go /usr/local && \ | ||
| rm -rf go && \ | ||
| rm go1.7.4.linux-amd64.tar.gz | ||
| COPY . /mint |
There was a problem hiding this comment.
Are we going to add a new Dockerfile.release which only does git clone version?
There was a problem hiding this comment.
yes, we will send an update shortly
harshavardhana
approved these changes
Jun 15, 2017
Fix mc scripts to return back to main script on failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite mint to create a framework for running SDK tests on Docker.
mc, minio-py, minio-go, minio-java, minio-js sdk tests have currently been added to the framework.
This is w.r.t issue #26