aws-sdk-php: fix AWS S3 compatible fixes #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
harshavardhana
force-pushed
the
fix-quick
branch
from
ea64db4
to
43488ef
Compare
harshavardhana
changed the title
krisis
requested changes
Apr 22, 2018
run/core/aws-sdk-php/quick-tests.php
Outdated
| @@ -646,7 +646,7 @@ function testGetBucketLocation($s3Client, $params) { | |||
| // Run failure tests. | |||
| $params = [ | |||
| // InvalidBucketName test | |||
There was a problem hiding this comment.
Nit: could we change the comment to be "Bucket not found test" instead of "invalidbucketname tests"?
run/core/aws-sdk-php/quick-tests.php
Outdated
| @@ -646,7 +646,7 @@ function testGetBucketLocation($s3Client, $params) { | |||
| // Run failure tests. | |||
| $params = [ | |||
| // InvalidBucketName test | |||
| 'InvalidBucketName' => ['Bucket' => $bucket . '--'], | |||
| 'NoSuchBucket' => ['Bucket' => $bucket . '--'], | |||
There was a problem hiding this comment.
Could we have a valid bucket name which is known up front to not exist during the test run instead of using an invalid bucket name?
There was a problem hiding this comment.
the reason is to verify S3 doesn't return invalid bucket name - since we know an invalid bucket name cannot exist - this is a good test still.
harshavardhana
force-pushed
the
fix-quick
branch
from
43488ef
to
1901fe3
Compare
nitisht
approved these changes
Apr 23, 2018
kannappanr
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.