Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sdk-php: fix AWS S3 compatible fixes #275

Merged
merged 1 commit into from
Apr 24, 2018
+9 −8
Merged

aws-sdk-php: fix AWS S3 compatible fixes #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
language: bash
sudo: true
dist: trusty
sudo: required
addons:
apt:
packages:
Expand Down
14 changes: 7 additions & 7 deletions run/core/aws-sdk-php/quick-tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,14 @@ function getStatusCode($result):string {
* $apiCall = 'headBucket'
* $exceptionMatcher = 'getStatusCode'
* $exceptionParamMap = [
* // Invalid bucket name
* '400' => ['Bucket' => $bucket['Name'] . '--'],
* // Non existent bucket
* '404' => ['Bucket' => $bucket['Name'] . '--'],
*
* // Non existent bucket
* '404' => ['Bucket' => $bucket['Name'] . '-non-existent'],
* ];
*
* @return string - HTTP status code. E.g, "400" for Bad Request.
* @return string - HTTP status code. E.g, "404" for Non existent bucket.
*/
function runExceptionalTests($s3Client, $apiCall, $exceptionMatcher, $exceptionParamMap) {
foreach($exceptionParamMap as $exn => $params) {
Expand Down Expand Up @@ -161,8 +161,8 @@ function testBucketExists(S3Client $s3Client) {

// Run failure tests
$params = [
// Invalid bucket name
'400' => ['Bucket' => $bucket['Name'] . '--'],
// Non existent bucket
'404' => ['Bucket' => $bucket['Name'] . '--'],

// Non existent bucket
'404' => ['Bucket' => $bucket['Name'] . '-non-existent'],
Expand Down Expand Up @@ -645,8 +645,8 @@ function testGetBucketLocation($s3Client, $params) {

// Run failure tests.
$params = [
// InvalidBucketName test
'InvalidBucketName' => ['Bucket' => $bucket . '--'],
// Non existent bucket
'NoSuchBucket' => ['Bucket' => $bucket . '--'],

// Bucket not found
'NoSuchBucket' => ['Bucket' => $bucket . '-non-existent'],
Expand Down