Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis build #70

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Add travis build #70

merged 1 commit into from
Jul 4, 2017

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Jul 3, 2017

This PR adds functionality to support building
docker image to test each PR on mint and also
make the built image available for testing.

Docker registry used is at https://play.minio.io/v2/mint/tags/list

@harshavardhana harshavardhana force-pushed the travis branch 18 times, most recently from a69f0af to f9f519c Compare July 4, 2017 02:08
@nitisht nitisht requested review from nitisht and krisis July 4, 2017 02:19
Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add details on how to use this in the README.

.travis.yml Outdated
services:
- docker
before_install:
- docker pull koalaman/shellcheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this if it isn't being used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for future use @krisis .. @nitisht is going to fix the issues reported by the shellcheck. Do you think don't add this otherwise?

This PR adds functionality to support building
docker image to test each PR on mint and also
make the built image available for testing.

Docker registry used is at https://play.minio.io/v2/mint/tags/list
@nitisht nitisht merged commit 6d7d264 into minio:master Jul 4, 2017
@harshavardhana harshavardhana deleted the travis branch July 4, 2017 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants