Add kubectl-minio plugin

[nitisht]

No description provided.

[nitisht]

This is ready for review now.

[kerneltime]

How is this used?

[nitisht]

@kerneltime here is the explanation on pkger file usage. I use this library https://github.com/markbates/pkger

• /static/crd.yaml & /static/cluster-role.yaml are added in this PR so they can be bundled within the kubectl-minio binary. This means these files are available for reading at runtime without depending on user to put a file in a specific location.

• Right now there is a duplication of crd.yaml and cluster-role.yaml. I can't use the files in parent directory because Pkger requires the files to be within the directory. Once this PR is in, and plugin is usable, we plan to remove the kustomize files and point the crdgen in makefile to this location.

• The pkger.go file is created by pkger command and it is a representation of the yaml files. We can add the pkger command in makefile as well.

[kannappanr]

@kerneltime PTAL

[kerneltime]

Nitish, I pushed a commit and rebased the branch.
Now the makefile target will pick up the latest autogenerated yaml and it is committed into code as well.
Also, I see that some of the yaml that we need to create the operator is generated by the plugin code. It would be best to pick up all the yaml from the same place and the plugin does not duplicate it.

[nitisht]

Also, I see that some of the yaml that we need to create the operator is generated by the plugin code. It would be best to pick up all the yaml from the same place and the plugin does not duplicate it.

@kerneltime I included the larger yamls (crd and cluster-role) that are sort of the moving parts and can change in future. Other yamls are smaller, and mostly static. Adding all the unnecessary yamls in the plugin will make plugin binary bigger and doesn't add any value. Plugin is generating all other yamls on the fly, there is no replication.

[harshavardhana]

This error message needs improvements

~  ./kubectl-minio tenant create --name boring --secret tls --servers 10 --volumes 10 --capacity 1Ti
Error: the server could not find the requested resource (post tenants.minio.min.io)

~ ./kubectl-minio tenant create --name boring --secret tls --servers 10 --volumes 10 --capacity 1TiB
Error: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'

Should fail with volumes is negative

~ ./kubectl-minio tenant create --name boring --secret tls --servers 10 --volumes -1 --capacity 1TiB
Error: --volumes should be a multiple of --servers

More undescriptive errors.

~  ./kubectl-minio tenant create --name boring --secret tls --servers -10 --volumes -10 --capacity 1Ti
Error: zone #0 cannot have 0 servers

Either this should be fixed in this PR or we should open issues for this, make a note and address them quickly before our GA.

~  ./kubectl-minio tenant upgrade --name test
Error: the server could not find the requested resource (get tenants.minio.min.io test)

~ ./kubectl-minio tenant volume add --name test --servers 10 --volumes 10 --capacity 1Ti
Error: the server could not find the requested resource (get tenants.minio.min.io test)

Volume add says its scale command

~ ./kubectl-minio tenant volume add --help

'scale' command adds zones to a MinIO Cluster tenant <---

Let's consistently use flag descriptions without capitalized characters

Flags:
      --capacity string        Total raw capacity of MinIO Tenant in this zone, e.g. 16Ti
  -h, --help                   help for add
      --name string            Name of the MinIO Tenant to be created, e.g. Tenant1
  -n, --namespace string       If present, the namespace scope for this request (default "default")
  -o, --output                 Dry run this command and generate requisite yaml
      --servers int32          Total number of pods in the MinIO Tenant, e.g. 4
  -s, --storage-class string   Storage Class to be used while PVC creation
      --volumes int32          Total number of volumes in the MinIO Tenant, e.g. 16. This should be a multiple of total servers provided under --servers flag.

Usage output lists --capacity twice

minio tenant volume add --name TENANT_NAME --server SERVERS --volumes VOLUMES --capacity --capacity VOLUME_CAPACITY [flags]

~ ./kubectl-minio tenant volume 

'tenant' command allows interaction with MinIO tenant's zones. --> should be `volume` command

Usage:
  minio tenant volume [command]

Available Commands:
  add         Add Storage Capacity to existing MinIO Tenant
  list        List MinIO Tenant zones --> list MinIO Tenant volumes? 

Flags:
  -h, --help   help for volume

Use "minio tenant volume [command] --help" for more information about a command.

Default help formatting is off

~ MinIO Operator plugin to manage MinIO operator CRDs

Usage:
  minio [command]

Examples:
  # Install MinIO Operator from the official GitHub repo.
        kubectl minio init [flags]

Available Commands:
  help        Help about any command
  operator    Create MinIO Operator
  tenant      Manage MinIO Cluster Tenant

Flags:
  -h, --help   help for minio

Use "minio [command] --help" for more information about a command.

[nitisht]

Addressed comments on error and help messages. PTAL @harshavardhana

[harshavardhana]

Sorry couldn't find time to look at this, will do it tomorrow.

[kerneltime]

Not in this PR but force delete of PVC can be added.

[Alevsk]

Can this be renamed to tenantConsoleConfig on a different PR?

[Alevsk]

Please rename variable to DefaultConsoleImage and use minio/console:v0.3.14

[Alevsk]

Please use console

[Alevsk]

tenantMCSLabels to tenantConsoleLabels and -mcs to -console

[Alevsk]

please use Console instead of MCS

[harshavardhana]

@nitisht PTAL at the comments from @Alevsk

[nitisht]

@nitisht PTAL at the comments from @Alevsk

Done in #261 cc @Alevsk