Simplify and speed up Object FindKey #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the length to reject candidates a bit quicker. ``` λ benchcmp before.txt after.txt benchmark old ns/op new ns/op delta BenchmarkNdjsonWarmCountStarWithWhere/iter-12 272527765 251116358 -7.86% benchmark old MB/s new MB/s speedup BenchmarkNdjsonWarmCountStarWithWhere/iter-12 1341.11 1455.46 1.09x ``` `countRawTapeWhere` is broken. I don't know if there is any point in fixing it. Old benchmark was broken.
|
@klauspost will take a look at the benchmark error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the length to reject candidates a bit quicker.
countRawTapeWhereis broken. I don't know if there is any point in fixing it. Old benchmark was broken.