map and expose miscellaneous fees to CCR bills #2101
Conversation
jsugarman
force-pushed
the
expose-misc-fees
branch
11 times, most recently
from
f48c698
to
9452ce0
Compare
| private | ||
|
|
||
| def quantity | ||
| 1.0 |
There was a problem hiding this comment.
Why deliberately set this to 1? Wouldn't the app/api force a value?
Or, does the fact that the fee exist often mean the quantity is one?
I'll keep reading... :)
There was a problem hiding this comment.
In CCR there is only ever one advocate fee. Ideally CCR should just assume this and the other hardcoded values and we can then do away with exposing quantity, rate and amount entirely.
will speak to @cibuanokpe about this, but this has been going exposed for a while now and am just exposing the same thing in a different way here.
| @@ -95,40 +95,56 @@ | |||
| }, | |||
| "number_of_cases": { | |||
| "id": "/properties/bills/items/properties/number_of_cases", | |||
| "type": "integer" | |||
| "type": "string" | |||
There was a problem hiding this comment.
Is this because CCR needs strings?
There was a problem hiding this comment.
Had a long slack chat with clem about this and we have settled on using strings for any number. BigDecimals, in particular, default to strings via the BigDecimal.to_json method. There is quite alot of chatter about this stuff e.g. rails/rails#25017 . rails used to have an override but it was removed for sensible reasons. I made integers strings too firstly for consistency (CCR can just assume strings and handled appropriately) but also was reading that the JSON datatype integer is not parsed consistently by some libraries in any event - meaning you could put a float/decimal in and might get away with it.
|
I restarted that build after a flickering test... Other than than that good to merge 👍 |
jsugarman
force-pushed
the
expose-misc-fees
branch
from
011a4a8
to
4e09864
Compare
What
Add CCR miscellaneous fee equivalents to the JSON api output
Why
For injection of equivalent CCCD fees into CCR.
NOTE
CCR miscellaneous fees are not synonymous with CCCD miscellaneous fees. Some
Basic Fees and Fixed fees in CCCD are handled as miscellaneous fees in CCR.