Session cache fix #143
Merged
Session cache fix #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Mar 2, 2017
| @@ -1,4 +1,4 @@ | |||
| <%= cache Session.maximum(:updated_at), expires_in: 20.seconds do %> | |||
| <%= cache [Session.maximum(:updated_at), current_participant], expires_in: 20.seconds do %> | |||
There was a problem hiding this comment.
Would you add a comment here about why we're using current participant as part of the cache key
| @@ -1,7 +1,7 @@ | |||
| <% title('All Sessions') %> | |||
| (most recently added first) | |||
|
|
|||
| <% cache @sessions do %> | |||
| <% cache [@sessions, current_participant] do %> | |||
There was a problem hiding this comment.
The comment’s just going to say “fragment contains user-specific info,” which I feel like the cache key itself already conveys. But I’ll add it.
jcoyne
approved these changes
Mar 2, 2017
|
Thanks for the speedy turnaround! |
jcoyne
reviewed
Mar 2, 2017
| @@ -1,4 +1,5 @@ | |||
| <%= cache Session.maximum(:updated_at), expires_in: 20.seconds do %> | |||
| <%# Note that fragment contains user-specific info, must be cached per user %> | |||
| <%= cache [Session.maximum(:updated_at), current_participant], expires_in: 20.seconds do %> | |||
There was a problem hiding this comment.
Where is the user-specific info? I can't find it. What partial?
There was a problem hiding this comment.
Here: https://github.com/minnestar/sessionizer/blob/master/src/app/views/sessions/_session.html.erb#L1
attending_class(session) gives results based on the current user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alex noted a bug where sessions would show as favorited (Minnestar icon next to them) even though the user hadn't favorited them. I believe this fixes the issue.
I also threw in a fix for a server error when logging out redundantly (log out, back, log out again).