-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule UI improvements #145
Conversation
src/app/models/session.rb
Outdated
@attendance_count ||= attendances.count | ||
end | ||
|
||
attr_writer :attendance_count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to say that we use this in preload_attendance_counts
as an optimization.
By in large these changes look good. Generally it would be helpful to other maintainers if you would add a bit more method documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I added a few light comments. Justin, LMK if there's stuff left that still seems unclear to you. |
@pcantrell thanks man! 😎 |
A grab bag: