Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mint start modifies source. #10

Closed
Camto opened this issue May 28, 2018 · 5 comments
Closed

mint start modifies source. #10

Camto opened this issue May 28, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request fixed in master The bug / feature is already fixed in master and will be in the next release
Milestone

Comments

@Camto
Copy link

Camto commented May 28, 2018

Running mint start changes the sources files to use two space indenting every time I save my files. This really confuses the text editors redo-undo feature, undoing makes Sublime text use half two space indenting and half tab indenting for whatever reason.

I think letting tabs be a thing would help "developer happiness" as something that is being focused on because for me, and other people using non two space indenting that automatic change can be a tad annoying.

@gdotdesign gdotdesign added question Further information is requested enhancement New feature or request and removed question Further information is requested labels May 28, 2018
@gdotdesign
Copy link
Member

There are two planned features that will help with this:

  1. Allow specifying the indent level or characters (2 spaces, 4 spaces, etc..) for the formatting
  2. Add a flag to the start command to turn off automatic formatting

I don't have an ETA for this, but it probably won't be long.

@manveru
Copy link
Contributor

manveru commented May 29, 2018

Might be worth mentioning that we could possibly read an .editorconfig http://editorconfig.org/ file that automates this configuration.

@gdotdesign
Copy link
Member

I think the .editorconfig is a good idea, anyone knows if there is a shard that parses that format?

@kingsleyh
Copy link

this should be easy to port to Crystal - however it only goes up to 0.9 and the latest is 0.12 - not sure what the difference in functionality is - I think it would take me a few hours to port this - however I don't want to support it or update it to 0.12 - as too busy at the moment.

https://github.com/editorconfig/editorconfig-core-ruby

@gdotdesign gdotdesign self-assigned this Feb 22, 2019
@gdotdesign gdotdesign added this to the 0.4.0 milestone Feb 22, 2019
@gdotdesign gdotdesign added the fixed in master The bug / feature is already fixed in master and will be in the next release label Feb 22, 2019
@gdotdesign
Copy link
Member

The indent-size can now be set in the mint.json file in the formatter-config object (in 0.4.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in master The bug / feature is already fixed in master and will be in the next release
Development

No branches or pull requests

4 participants