Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty converted icons #413

Closed
sergejsha opened this issue May 9, 2021 · 2 comments
Closed

Empty converted icons #413

sergejsha opened this issue May 9, 2021 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@sergejsha
Copy link

If imagemagick is not installed locally, all converted icons in dist folder have size of 0 bytes. mint build reports no errors.

Expected behavior:
mint build shall

  • either report an error with a hint to install imagemagick
  • or imagemagick is installed with mint

Mint version 0.12.0

@Sija Sija added the bug Something isn't working label May 9, 2021
@Sija
Copy link
Member

Sija commented May 9, 2021

Confirmed, offending code (no error handling):

def convert(image, size)
output =
IO::Memory.new
error =
IO::Memory.new
status =
Process.run(
"convert #{image} -resize #{size}x#{size} -",
shell: true, error: error, output: output)
if status.success?
output.to_s
else
""
end
end

@gdotdesign gdotdesign added this to the 0.13.0 milestone May 10, 2021
@sergejsha
Copy link
Author

Looks good. Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants