Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can you please resolve the deprecation ember-cli-version-checker ? #75

Closed
tigressbailey opened this issue Mar 22, 2018 · 4 comments
Closed

Can you please resolve the deprecation ember-cli-version-checker ? #75

tigressbailey opened this issue Mar 22, 2018 · 4 comments

Comments

@tigressbailey
Copy link

The message keeps showing when moving the can service into an engine.

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   DependencyVersionChecker.NPMDependencyVersionChecker (/Users/bzhang2/Project/mg-ui/node_modules/ember-can/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:32)
@denzo
Copy link

denzo commented Mar 22, 2018

🙏

@Exelord
Copy link
Collaborator

Exelord commented Apr 1, 2018

This should be also fixed by #74

@blimmer blimmer closed this as completed Apr 1, 2018
@tigressbailey
Copy link
Author

@Exelord Thank you so much~
@blimmer Did we release the v.1.0.0 already?

@tigressbailey
Copy link
Author

@Exelord and @blimmer Thanks. This issue is resolved as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@blimmer @Exelord @denzo @tigressbailey