Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent template's contents rendering in wormhole when app is launched from child route #14

Open
stickbyatlas opened this issue Mar 12, 2018 · 0 comments

Comments

@stickbyatlas
Copy link

Hi folks,

Using Ember 2.13.4 and v0.1.0 of this library.

I'm trying to set up my application's navbar so that it displays default content for most of the application's routes, but can occasionally be overridden.

To do this, in my application.hbs template, I have a {{#portal-for name='navbar'}} , and in the same template I have a {{#portal-content for='navbar'}} that renders the default contents for the application.

In a child route where I want to customize the navbar's content, I have another {{#portal-content for='navbar'}} block. When I load the application from the index route, and navigate to the child route, the navbar's contents are replaced as expected. Going back to the index route restores the default content from the application.hbs, as index.hbs template doesn't have a custom portal.

However, when I load the application directly from the child route, the wormhole displays the default content from the application.hbs template. Navigating to index, and then back to the child route fixes the problem.

I see several deprecation warnings in the console:

Importing from the `ember-component` module has been deprecated.
Importing from the `ember-service/inject` module has been deprecated.
Importing from the `ember-computed` module has been deprecated. 
Importing from the `ember-service` module has been deprecated.
Importing from the `ember-runloop` module has been deprecated.

In previous versions of Ember (2.4.x with version 0.0.5 of this add-on), the method I've described above has worked for me. Is this something a simple hot fix can address, or has the addon changed since it hit 0.1.0?

Please advise, and thanks for this fantastic addon. It's saved me so much time and spared me so many headaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant