Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems that other language is not supported by youtube downloader #571

Open
wisetc opened this issue Sep 8, 2023 · 9 comments
Open

It seems that other language is not supported by youtube downloader #571

wisetc opened this issue Sep 8, 2023 · 9 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@wisetc
Copy link

wisetc commented Sep 8, 2023

It seems that language and location params are configured fixed

{
  hl: 'en',
  gl: 'US',
}

Can we set it dynamically?

@miraclx
Copy link
Owner

miraclx commented Sep 8, 2023

Can you provide a use case? What are you trying to do that isn't working?

@wisetc
Copy link
Author

wisetc commented Sep 8, 2023

@miraclx

docker run --rm -it --entrypoint bash --name freyrcli -v $PWD:/data -v ./conf.json:/freyr/conf.json freyrcli/freyrjs-git:pr-214 -c "freyr apple_music:track:157624199"
266641497-6d6b866e-8f15-4851-83e2-0b0486a2759e

as you can see, Zero sources found.

but indeed, we can get result from youtube music

image

How can I download it?

@miraclx
Copy link
Owner

miraclx commented Sep 8, 2023

I'll take a look. Thanks.

@wisetc
Copy link
Author

wisetc commented Sep 9, 2023

Top result is not included in result.

    TITLE_TEXT: ['title', 'runs', 0, 'text'],
    HEADER_TITLE_TEXT: ['header', 'title', 'runs', 0, 'text'],

maybe "Top result" always using a header

image

And I think that language settings is not related to this issue as mentioned above. I'm wrong.

@wisetc
Copy link
Author

wisetc commented Sep 10, 2023

It seems that stripText will remove characters when calling StripChar.RSspecChar.

StripChar RSspecCharC' 1 q好 1d)

I don't think need to be striped.

maybe it works well when dealing with english songs, thanks for your work.

I'm just reporting this case.

@miraclx
Copy link
Owner

miraclx commented Sep 10, 2023

Valid point, I hadn't tested with non-Latin glyphs. What is this string? File name? Track name?

@wisetc
Copy link
Author

wisetc commented Sep 10, 2023

Valid point, I hadn't tested with non-Latin glyphs. What is this string? File name? Track name?

@miraclx Track name.

for example: 忙與盲

thank you.

@miraclx
Copy link
Owner

miraclx commented Sep 12, 2023

non-Latin support for source feed lookups implemented in #574. Thanks for raising this.

@miraclx miraclx added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 1, 2024
@miraclx
Copy link
Owner

miraclx commented Jan 1, 2024

Just leaving a note here: The issue left here (may) be tied to the issue in #576, and could be resolved by a single fix that merges track results in all sections from the YouTube Music search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants