Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a Msg of string instead of a simple string when we got an error #36

Open
dinosaure opened this issue Nov 14, 2021 · 1 comment
Open

Comments

@dinosaure
Copy link
Member

In keys.ml, we returns a simple string which does not compose well with rresult when this package is available (specially with mirage). It should be nice to return an Msg of string, and, by this way, be able to use for instance Rresult.R.failwith_error_msg.

@hannesm
Copy link
Member

hannesm commented Nov 25, 2021

I agree that this would be very fine -- though I'd also avoid a rresult dependency in this package (it is >= 4.08.0 anyways, which has a decent Result module).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants