Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh actions: update to opam 2.1 invocation and refresh compiler versions #135

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

avsm
Copy link
Member

@avsm avsm commented Jul 28, 2021

No description provided.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/windows.yml Outdated Show resolved Hide resolved
@smorimoto
Copy link
Contributor

We may have to avoid depext for this only on the Windows runners. (or we can make more fundamental improvements!)

available: os != "win32"

Co-authored-by: Sora Morimoto <sora@morimoto.io>
@hannesm
Copy link
Member

hannesm commented Aug 2, 2021

Thanks for this PR. Unfortunately this changes the set of CI failures, but does not fix all. Namely, the windows CI (that uses a separate configuration file) avoided the installation of mirage-crypto-rng-async -- it looks like the new "setup-ocaml" doesn't care about that.

@smorimoto
Copy link
Contributor

2.1 has been temporarily disabled. v2 uses the latest opam < 2.1. Native Windows support is planned to be introduced in 2.2, so we will unlock this constraint when it is released.

@smorimoto
Copy link
Contributor

For issues on Windows, it may be enough to simply disable auto depext.

@hannesm
Copy link
Member

hannesm commented Aug 9, 2021

I looked into the ocaml/setup-ocaml documentation (and examples), and tried with a subsequent commit (efb13ff) -- happy to see whether this works as expected (and hear your thoughts). indeed, the mirage-crypto-rng-async opam package is not supported on windows.

@hannesm hannesm merged commit 840f50b into mirage:main Aug 9, 2021
hannesm added a commit to hannesm/opam-repository that referenced this pull request Oct 25, 2021
…age, mirage-crypto-rng-async, mirage-crypto-pk and mirage-crypto-ec (0.10.4)

CHANGES:

- hash: ensure alignment of data, fixes arm32 test cases (mirage/mirage-crypto#143 @hannesm)
- drop sexplib and ppx_sexp_conv dependencies (mirage/mirage-crypto#141 @hannesm)
- install LICENSE files of different opam packages
- require eqaf >= 0.8 to avoid bigarray-compat dependency (mirage/mirage-crypto#139 by @hannesm)
- update to GH actions 2.1, fix windows action (mirage/mirage-crypto#135 mirage/mirage-crypto#139 @avsm @smorimoto)
- drop rresult dependency (mirage/mirage-crypto#139 mirage/mirage-crypto#141 by @hannesm @reynir)
- avoid deprecated Cstruct.len, use Cstruct.length instead (mirage/mirage-crypto#134 by @hannesm)
- mirage-crypto-pk: adapt to mirage 4 (mirage/mirage-crypto#141 @TheLortex @samoht)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants