On Windows, run PKG_CONFIG_PATH through cygpath
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @hannesm, @dinosaure |
When using OCaml in Windows, PKG_CONFIG_PATH is usually in Windows style. GNU Make with the shell function will call Cygwin's Unix shell which doesn't recognize Windows paths. If we're on a Windows system, and if we find cygpath, convert the path list to Unix style.
MisterDA
force-pushed
the
windows-build
branch
from
cdfd177
to
a08015b
Compare
|
yes, this patch looks good. would it be fine with you to defer that until we've mirage4 out and can remove these Makefiles completely? |
|
Yep, I'll just pin the package.
|
|
Thanks. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Mar 29, 2022
…age, mirage-crypto-rng-async, mirage-crypto-pk and mirage-crypto-ec (0.10.6) CHANGES: - Use _WIN32 instead of __WIN32__, as proposed by @jonahbeckford in mirage/mirage-crypto#137 - PKG_CONFIG_PATH via cygpath on Window (mirage/mirage-crypto#150 @MisterDA) - ocaml-solo5 (formerly ocaml-freestanding) defines __ocaml_solo5__, use this in ifdef (arm only, mirage/mirage-crypto#152 @hannesm) - mirag-crypto-rng-mirage test: require mirage-unix >= 5.0.0 (mirage/mirage-crypto#151 @hannesm) - use oUnit2 as dependency, instead of oUnit (mirage/mirage-crypto#149 @MisterDA) - support mipsel and mips64el compilation (mirage/mirage-crypto#148 @glondu) - bugfix: define _POSIX_C_SOURCE in entropy_cpu_stubs.c (otherwise clock_gettime is not defined - at least on armhf) (mirage/mirage-crypto#148 @glondu) - bugfix: compilation on kfreebsd-* (adding __FreeBSD_kernel__ to ifdef) (mirage/mirage-crypto#148 @glondu)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using OCaml in Windows,
PKG_CONFIG_PATHis usually in Windowsstyle. GNU Make with the
shellfunction will call Cygwin's Unix shellwhich doesn't recognize Windows paths. If we're on a Windows system,
and if we find
cygpath, convert the path list to Unix style.This is the same patch that I've pushed to mirage-tcpip and elsewhere.