Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github actions: actually build the code and execute the tests #154

Merged
merged 1 commit into from Jun 21, 2022
Merged

github actions: actually build the code and execute the tests #154

merged 1 commit into from Jun 21, 2022

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Apr 5, 2022

//cc @avsm @smorimoto to me it looks like the github actions do not compile the code and run the tests at the moment!?

@hannesm
github actions: actually build the code and execute the tests
cbf36fd 
The building and test execution was disabled in 840f50b
@hannesm
Copy link
Member Author

hannesm commented May 30, 2022

Hmm, unfortuately I don't quite understand setup-ocaml, and now when re-adding the package names to windows.yml, suddenly all these CI jobs fail with bad hash -- any clue whether this is a temporary issue, or are the windows CI systems in a desolate state? //cc @smorimoto

@avsm
Copy link
Member

avsm commented May 31, 2022

Not sure what's wrong here -- looks like a bug in setup-ocaml.

@hannesm
Copy link
Member Author

hannesm commented Jun 21, 2022

I restarted the GitHub actions, and the windows compilation succeeds now.

@EduardoRFS would you be able to take a look into the cross-compilation CI and why it is failing? it complains about missing dune-configurator, but I've no clue where to adjust that... also, mirage-crypto opam file has a dependency onto dune-configuratior.

@hannesm hannesm merged commit 6a5d983 into mirage:main Jun 21, 2022
@hannesm hannesm deleted the ci branch June 21, 2022 11:29
@EduardoRFS
Copy link
Contributor

EduardoRFS commented Jun 21, 2022 •
edited

@hannesm feel free to remove it, I will not have time in the near future to maintain it, I apologize for the stress

@hannesm
Copy link
Member Author

hannesm commented Jun 21, 2022

@EduardoRFS ok, thanks.

@hannesm hannesm mentioned this pull request Sep 13, 2022
Merged
hannesm added a commit to hannesm/opam-repository that referenced this pull request Sep 13, 2022
@hannesm
[new release] mirage-crypto, mirage-crypto-rng, mirage-crypto-rng-mir…
a19b5ec 
…age, mirage-crypto-rng-eio, mirage-crypto-rng-async, mirage-crypto-pk and mirage-crypto-ec (0.10.7)

CHANGES:

- mirage-crypto-rng-eio: new package for seeding and feeding entropy to the
  rng with eio (mirage/mirage-crypto#155 @bikallem, @talex5, @hannesm)
- mirage-crypto-ec: expose Dsa.byte_length (mirage/mirage-crypto#164 @hannesm)
- CI: various fixes (mirage/mirage-crypto#154 mirage/mirage-crypto#164 @hannesm)
- mirage-crypto-rng-mirage: use 'a generator type alias
- mirage-crypto-rng: improve setup_rng message (add async, revise lwt) (mirage/mirage-crypto#161
  @hannesm)
- mirage-crypto-rng-mirage: always feed the default generator (as done in
  a8c7bbd2552a9d2177450e95f280342f80fba01d for the lwt feeding) (mirage/mirage-crypto#161 @hannesm)
- ec: update generated code to recent fiat-crypto (mirage/mirage-crypto#156 @hannesm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hannesm @avsm @EduardoRFS