Test cases for symmetric ciphers with empty input for encrypt and deccrypt #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rypt Also, fix mirage#172 by providing a `0` case in the chache20 crypt loop
|
This is as well what I arrived at in https://github.com/reynir/mirage-crypto/tree/fix-chacha20. I tested a few values against a python implementation and got the same results. I can't say I understand chacha20 so take it with a LD50 dose of salt. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Mar 9, 2023
…age, mirage-crypto-rng-lwt, mirage-crypto-rng-eio, mirage-crypto-rng-async, mirage-crypto-pk and mirage-crypto-ec (0.11.1) CHANGES: * BUGFIX Chacha20 decrypt and encrypt with empty data (previously lead to segmentation fault, reported by @smondet in mirage/mirage-crypto#172, fix in mirage/mirage-crypto#173 by @reynir @hannesm), added tests with empty data for all symmetric ciphers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix #172 by providing a
0case in the chache20 crypt loop