Update fiat #177
Closed
Update fiat #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, but since there are no code changes, I doubt it'll work on your systems. |
|
I indeed do see the same error as before with this PR. |
|
@dmmulroy see the discussions here: mit-plv/fiat-crypto#1606 it seems to be due to a bug introduced in clang 14.0.3. I've reported an issue to Apple, but no news so far... |
|
@samoht Thank you for the context and link - I'll keep my eyes peeled on the issues 👀 |
|
since the main difference is "inline everything", a performance evaluation is needed before a merge. |
|
since it is only inlining the change, I'll defer to a later point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.