ccm gcm adjustments #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
emillon
approved these changes
Feb 26, 2020
avsm
approved these changes
Feb 26, 2020
|
this changes the behaviour of GCM (now raise on empty IV), this is fine for the time being -- note that protocols on top of GCM (such as TLS - https://tools.ietf.org/html/rfc5288#section-3 where a 4 byte implicit salt (derived from KDF) and a 8 byte explicit nonce (transported in the packed) are used -- thus a bad packet (too short) will be detected before GCM.decrypt is called -- or phrased differently: any use of GCM in TLS will never provide an empty IV, but always one of 12 bytes) ensure that the IV will never be empty. there may be in the future a no-exception-leaking interface for mirage-crypto, but that may be rather inconvenient to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commit messages for more details